Rock Band, seeing how I like the songs that are on it way better than the selection from Guitar Hero. It's also got pretty good multiplayer instead of waiting for a guitar or two to get passed around
Depends on the situation. Rock Band is only fun if there's more people. Since I'm generally a solo player, I have to go with Guitar Hero. Rock Band is also WAY too easy when it comes to the guitar parts anyways. Plus there's like 3 good songs on it. Granted there's like 5 on GH3, but I play GH1 anyways (where 90% of the set list is epic... songs like Frankenstein, Bark at the Moon, Texas Flood, Ironman, Killer Queen... the list goes on and on, and gets more and more epic).
Guitar hero, because it was first game with guitar! Rock band stole their idea! that is not fair. Its also way way way funner. I bet the new one is gonna be even better.