Forums → Programming Forum → Problem with my Gravity and jump code

A. whats wrong with it

B. as3 or as2

A. It isn't jumping or have gravity, it just auto animates and stays in place.

B. AS2

well sorry, i could help you if it was as3

Well, it's a pretty messy solution in my opinion. Also, I don't get the point of those returns. If you delete those leftisdown and rightisdown functions, it would be better. Just write
If ( Key.isDown(Key.LEFT))
{
        Char.gotoAndStop(2);
        Char.accel -= 1;
        Char._xscale = -100;
}

IMO you should make some booleans which go true if key is pressed and false on key up. also keep a boolean for hitTest with ground that way you dont have to calculate it every time. I dunno how you are trying to jump here is some code that might help

jumpInter = setInterval(jumpAction, 40);
}

public function jumpAction()
{
char.y += 20;
if (char.y >= 110)
{
char.y = 110;
clearInterval(jumpInter);
jumpInter = setInterval(stopJump, 40);
}
}

public function stopJump()
{
char.y -= 20;
if (char.y <= -50)
{
char.y = -50;
clearInterval(jumpInter);
jumpInter = -1;
}
}

In here I set a setInterval to jump up and then I come down. you can use your gravity thing with this and in stop jump you can check hitTest with ground to stop the character going down. Hope this helps.

That's as3, googly :S
And however, I think that will be like all way up, hitting something invisible and all way down. If you want a more realistic effect you should write
if (Key.isDown(Key.UP))
{
jumping = true
}
if (jumping == true)
{
char._y -= jumpspeed
jumpspeed -= 1
}
if (!Char.ground.hitTest( _x,_y, true))
{
jumping = false
jumpspeed = the starting value
}
so, when jumpspeed become 0 the character will stop in the air for a moment, then jumpspeed will become a negative value and the character will start falling

hey gabo... I meant to give the logic only, I never said will give the code in as2... its just logic.... if you didnt read my post let me say again "IMO you should make some booleans which go true if key is pressed and false on key up. also keep a boolean for hitTest with ground that way you dont have to calculate it every time." which is what u have done.... I was just giving a substitute code...

Yep, you're right about the hitTest part, a Boolean would have simplified stuff. Sorry, i forgot about it.

this is the code i use in as2, its easy to change up and i just have it saved in a text doc, change what you need


onClipEvent (load) {
var ground:MovieClip = _root.ground;
var grav:Number = 0;
var gravity:Number = 2;
var speed:Number = 15;
var maxJump:Number = -20;
var touchingGround:Boolean = false;
}
onClipEvent (enterFrame) {
_y += grav;
grav += gravity;
while (ground.hitTest(_x, _y, true)) {
_y -= gravity;
grav = 0;
}
if (ground.hitTest(_x, _y+5, true)) {
touchingGround = true;
} else {
touchingGround = false;
}
if (Key.isDown(Key.RIGHT)) {
_x += speed;
}
if (Key.isDown(Key.LEFT)) {
_x -= speed;
}
if (Key.isDown(Key.UP) && touchingGround) {
grav = maxJump;
}
if (ground.hitTest(_x+(_width/2), _y-(_height/2), true)) {
_x -= speed;
}
if (ground.hitTest(_x-(_width/2), _y-(_height/2), true)) {
_x += speed;
}
if (ground.hitTest(_x, _y-(height), true)) {
grav = 3;
}
}